Fix keybind documentation: use return instead of enter#5282
Fix keybind documentation: use return instead of enter#5282StevenTCramer wants to merge 1 commit intoanomalyco:devfrom
Conversation
Fix keybind documentation: use return instead of enter The keybind parser doesn't normalize enter to return, but the terminal sends key events as return. This causes keybinds using enter (like input_submit: "enter" and input_newline: "shift+enter") to silently fail. Updated all instances of enter to return to match what the terminal actually sends and what the code expects internally.
|
Hello, I've already modified the return but the problem still persists. Why is that? |
|
@StevenTCramer newer versions should actually alias return/enter both ways. |
When I’m using the OpenCode extension in VS Code, neither the Return key nor the Enter key works. What’s causing this issue? I tried setting Shift + Enter to insert a new line, but it still doesn’t work — the only thing that works is Control + J. |
|
@Ruagewei the issue is that xterm.js that is used in vscode does not support alternate keys/modify other keys, neither CSI u nor kitty keyboard. There is no way to get modifiers for the enter/return key, so the terminal always just sends \r. The only way is to setup a custom key binding in the vscode config to send \n for shift+enter. |
opencode-agent
bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
3 times, most recently
from
f1ae801 to
08fa7f7
Compare
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
3 participants
Fix keybind documentation: use return instead of enter
The keybind parser doesn't normalize enter to return, but the terminal sends key events as return. This causes keybinds using enter (like input_submit: "enter" and input_newline: "shift+enter") to silently fail.
Updated all instances of enter to return to match what the terminal actually sends and what the code expects internally.